mpd: add uri and filename format arguments #3849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people have files in their music library that are not properly tagged and for such files
{title}and{album}cannot be displayed by the mpd module. As a fallback the user might want to display filename or the full URI of this file instead ( see #3631 ).This PR
{filename}format replacement to be used in tooltips (previously only available in the label, for some reason){filename}format replacement in the man page{uri}format replacement which takes the value ofmpd_song_get_uriWhile this does not allow to display the filename conditionally on the title being empty (format strings like
{title|filename}don't seem to be allowed), at least one can now display the URI of the file in the tooltip and get a hint which file is missing proper tagging.