Gtk4 #3857
Open
Gtk4 #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktar Lukashonak <[email protected]>
Add suport for menus and menu actions in label modules with GTK4. This changes the format of the interface file used for the menu. Instead of defining a GtkMenu, use `<menu>` to define a menu model. TODO: Update documentation
Also fix a warning about unneeded catch in power_profiles
Resolving conflicts with f9acc1f (Alexays#3730) was a somewhat complicated. Conflicts: include/AModule.hpp src/AModule.cpp src/bar.cpp src/modules/network.cpp src/util/backlight_backend.cpp
|
Changed the base to master, because the gtk4 branch on this repo is very out of date. I also merged current master into the branch. For some reason I can't make a PR against the LukashonakV repo. |
tmccombs
commented
Jan 2, 2025
| if (dir == SCROLL_DIR::NONE) { | ||
| return true; | ||
| } | ||
|
|
||
| int step = 5; | ||
| int step{5}; | ||
| if (config_["scroll-step"].isInt()) { |
There was a problem hiding this comment.
Does it ever make sense for this to be negative? If not, we could read this as a UInt, and avoid some casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of https://github.com/LukashonakV/Waybar/tree/gtk4 (see also #2956), but adds back suport for the general
menuconfiguration, using aGio::MenuModelandGtk::PopoverMenuinstead of aGtk::Menu.