Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetpack-compose-migration: ReadHistory, FeaturedReading, FeaturedDua, QuranSolution, QuranEtiquette, FeatureProphets & QuranScience #442

Closed
wants to merge 26 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2024

I migrated to Jetpack Compose the readHistory section of the home screen. The only problem is when deleting or adding readhistory elements, the section doesn't reflect the updated data because it needs a viewModel. I let you do that and the room database so that I can follow your approach in the future migrations that I'll do. About the color theme of the app for now I reused the already defined xml.

@faisalcodes
Copy link
Member

Can you look at the view models here.

@ghost ghost changed the title jetpack-compose-migration: ReadHistorySection jetpack-compose-migration: ReadHistory Feb 10, 2024
@faisalcodes
Copy link
Member

Sorry, I could not get time :( I'll review and merge it soon.

@faisalcodes
Copy link
Member

faisalcodes commented Feb 15, 2024

Great work @arkibax. This will make the further development easier. Just a few things -

  1. There is an issue with theme in the History screen and history item (dark and light mode)
  2. Can we match the style of ButtonAlphaSmall and BoldHeader with the previous style
  3. Touching the history item feels kind of old. Either we can add a ripple or match with the previous style.

You can also install the production version side-by-side for reference.

@faisalcodes
Copy link
Member

I am currently unable to work on migration due to lack of time.

@faisalcodes
Copy link
Member

Great work! I'll take a look.

@ghost ghost changed the title jetpack-compose-migration: ReadHistory jetpack-compose-migration: ReadHistory, FeaturedReading, FeaturedDua, QuranSolution, QuranEtiquette, FeatureProphets & QuranScience Mar 10, 2024
@faisalcodes
Copy link
Member

I have fixed some UI issues. ReadHistotyScreen needs to be fixed further before it can be merged.

  • BoldHeader
  • Background/status bar color
  • Item gets removed on slight swipe

@faisalcodes
Copy link
Member

faisalcodes commented Mar 12, 2024

No worries, I'll look into this.

Ramadan Mubarak!

@faisalcodes
Copy link
Member

Would you like to contribute to alfaazplus/SunnahApp? The app is still in development.

@faisalcodes
Copy link
Member

Sorry, I couldn't see your edit.

The app was still in development, there could be some issue loading the home screen.

@ghost ghost closed this by deleting the head repository Aug 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant