Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-9044 Remove excluded files from war file for SAST #3084

Merged
merged 15 commits into from
Dec 20, 2024

Conversation

SaraAspery
Copy link
Contributor

No description provided.

Copy link



Scan Summary:
PIPELINE_SCAN_VERSION: 24.12.1-0
DEV-STAGE: DEVELOPMENT
PROJECT-NAME: alfresco-community-repo
SCAN_ID: 1a096fdb-04b9-4709-a308-bcf548a0604c
SCAN_STATUS: SUCCESS
SCAN_MESSAGE: Scan successful. Results size: 10760 bytes
====================
Analysis Successful.
====================

==========================
Found 2 Scannable modules.
==========================
alfresco.war
JS files within alfresco.war

===================
Analyzed 2 modules.
===================
alfresco.war
JS files within alfresco.war

==================
Analyzed 5 issues.
==================

details


--------------------------------
Found 1 issues of High severity.
--------------------------------
CWE-80: Improper Neutralization of Script-Related HTML Tags in a Web Page (Basic XSS): org/springframework/security/spring-security-webauthn.js:199
Details: This call to href() contains a cross-site scripting (XSS) flaw. The application populates the HTTP response with untrusted input, allowing an attacker to embed malicious content, such as Javascript code, which will be executed in the context of the victim's browser. XSS vulnerabilities are commonly exploited to steal or manipulate cookies, modify presentation of content, and compromise confidential information, with new attack vectors being discovered on a regular basis. Use contextual escaping on all untrusted data before using it to construct any portion of an HTTP response. The escaping method should be chosen based on the specific use case of the untrusted data, otherwise it may not protect fully against the attack. For example, if the data is being written to the body of an HTML page, use HTML entity escaping; if the data is being written to an attribute, use attribute escaping; etc. Both the OWASP Java Encoder library and the Microsoft AntiXSS library provide contextual escaping methods. For more details on contextual escaping, see https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.md. In addition, as a best practice, always validate untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible. References: CWE OWASP Supported Cleansers
https://downloads.veracode.com/securityscan/cwe/v4/java/80.html
----------------------------------
Found 1 issues of Medium severity.
----------------------------------
CWE-601: URL Redirection to Untrusted Site ('Open Redirect'): org/springframework/security/spring-security-webauthn.js:199
Details: This call to href() contains a URL redirection to untrusted site flaw. Writing untrusted input into a URL value could cause the web application to redirect the request to the specified URL, leading to phishing attempts to steal user credentials. Always validate untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible. References: CWE OWASP
https://downloads.veracode.com/securityscan/cwe/v4/java/601.html
--------------------------------------------
Skipping 1 issues of Informational severity.
--------------------------------------------

Total flaws found: 5, New flaws found: 2 as compared to baseline


========================
FAILURE: Found 2 issues!
========================

[12 Dec 2024 15:20:12,0313] PIPELINE-SCAN INFO: Writing Scan Summary to file '/home/runner/work/alfresco-community-repo/alfresco-community-repo/results.json'.

@SaraAspery SaraAspery changed the title ACS-9044 Bump dependency.spring.version from 6.1.14 to 6.2.0 ACS-9044 Remove excluded files from war file for SAST Dec 19, 2024
pushd "$(dirname "${BASH_SOURCE[0]}")/../../"

# Copy war file to temporary directory
/bin/cp -f "$1" "$2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need /bin/cp instead of just cp?

@SaraAspery SaraAspery merged commit 4eafb13 into master Dec 20, 2024
89 checks passed
@SaraAspery SaraAspery deleted the feature/ACS-9044_SAST_scans_too_many_files branch December 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants