Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-9039 fix for export aca-playwright-shared lib #4317

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+15 −10
Open

ACS-9039 fix for export aca-playwright-shared lib #4317

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
681707a
ACS-9039 fix for export lib
akashrathod28 Dec 23, 2024
a8a4759
Update project.json to remove test config
akashrathod28 Dec 23, 2024
25f16dd
update package version
akashrathod28 Dec 23, 2024
d1ba352
update package dependancy
akashrathod28 Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions projects/aca-playwright-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,28 @@
{
"name": "@alfresco/aca-playwright-shared",
"name": "@alfresco/aca-akash",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this name correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out, I will fix this.

"version": "0.0.1",
"commit": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need that?

Copy link
Contributor Author

@akashrathod28 akashrathod28 Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can remove this .

"license": "LGPL-3.0",
"dependencies": {
"tslib": "^2.0.0"
},
"publishConfig": {
"access": "public"
"scripts": {},
"peerDependencies": {
"@alfresco/adf-content-services": "7.0.0-alpha.7-12408701331",
"@alfresco/adf-core": "7.0.0-alpha.7-12408701331",
"@alfresco/adf-extensions": "7.0.0-alpha.7-12408701331",
"@alfresco/eslint-plugin-eslint-angular": "7.0.0-alpha.7-12408701331",
"@alfresco/js-api": "8.0.0-alpha.7-12408701331",
"@angular/animations": ">=15.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need angular as dependency for playwirght code right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I removed them

"@angular/common": ">=15.2",
"@angular/compiler": ">=15.2",
"@angular/core": ">=15.2",
"@angular/forms": ">=15.2",
"@angular/material": ">=15.2",
"@ngrx/effects": ">=15.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here do you use any effects in the playwright code?

"@ngrx/router-store": ">=15.2",
"@ngrx/store": ">=15.2",
"@ngx-translate/core": ">=14.0.0",
"rxjs": ">=6.6.6",
"tslib": ">=2.0.0",
"zone.js": ">=0.11.8"
},
"repository": {
"type": "git",
Expand Down
4 changes: 1 addition & 3 deletions projects/aca-playwright-shared/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
}
},
"defaultConfiguration": "production",
"outputs": [
"{workspaceRoot}/dist/@alfresco/aca-playwright-shared"
]
"outputs": ["{workspaceRoot}/dist/@alfresco/aca-playwright-shared"]
},
"lint": {
"executor": "@angular-eslint/builder:lint"
Expand Down
5 changes: 4 additions & 1 deletion projects/aca-playwright-shared/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"target": "es2020",
"module": "es2015",
"moduleResolution": "node",
"declaration": true,
"sourceMap": true,
Expand All @@ -11,7 +13,8 @@
"experimentalDecorators": true,
"importHelpers": true,
"types": [],
"lib": ["dom", "es2020"]
"lib": ["dom", "es2018"],
"paths": {}
},
"angularCompilerOptions": {
"skipTemplateCodegen": true,
Expand Down
1 change: 1 addition & 0 deletions tsconfig.adf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@alfresco/aca-content/viewer": ["projects/aca-content/viewer/src/public-api.ts"],
"@alfresco/aca-content/preview": ["projects/aca-content/preview/src/public-api.ts"],
"@alfresco/aca-playwright-shared": ["projects/aca-playwright-shared/src/public-api.ts"],
"@alfresco/aca-playwright-shared/*": ["projects/aca-playwright-shared/src/*/index.ts"],
"package.json": ["package.json"],
"*": ["./node_modules/*"]
}
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@alfresco/aca-shared/rules": ["projects/aca-shared/rules/src/public-api.ts"],
"@alfresco/aca-shared/store": ["projects/aca-shared/store/src/public-api.ts"],
"@alfresco/aca-playwright-shared": ["projects/aca-playwright-shared/src/public-api.ts"],
"@alfresco/aca-playwright-shared/*": ["projects/aca-playwright-shared/src/*/index.ts"],
"package.json": ["package.json"]
}
},
Expand Down
Loading