Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructor of acset from FinDomFunctor in varacset case #917

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

KevinDCarlson
Copy link
Contributor

The constructor (T)(::FinDomFunctor) where T<:ACSet did not previously add any parts at AttrTypes, which is necessary in case where some of the input's attributes take AttrVar values. We now add such AttrVars, only when they're definitely needed, to avoid dangling AttrVars, which are quite dangerous.

@KevinDCarlson KevinDCarlson requested a review from epatters June 26, 2024 23:55
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

@epatters epatters changed the title Correct constructor of acset from findomfunctor for varacset case Fix constructor of acset from FinDomFunctor in varacset case Jun 27, 2024
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin!

@epatters epatters merged commit 91f21a9 into main Jun 27, 2024
10 checks passed
@epatters epatters deleted the constructVaracsetFromFindomfunctor branch June 27, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants