Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean deps for new release #127

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Clean deps for new release #127

merged 5 commits into from
Nov 20, 2024

Conversation

GeorgeR227
Copy link
Contributor

These packages had no compat entries and upon further inspection were not being used. I'm removing them now since this is blocking the triggering of a new release.

Perhaps we should also add Aqua.jl to this package to avoid this kind of issue in the further.

These packages had no compat entries and upon further inspection were not being used.
@lukem12345
Copy link
Member

Yeah you have to close CompatHelper PRs before triggering a release

@GeorgeR227
Copy link
Contributor Author

Ok, then I can bump MeshIO and GeometryBasics here since it seems like they're stepping on each other in the compat PRs. I'll close the PRs for AlgebraicInterfaces, LinearSolve, and RowEchelon since those have all been removed now.

Upon tests passing we can close compathelper's PRs
@GeorgeR227
Copy link
Contributor Author

GeorgeR227 commented Nov 20, 2024

Also seems like a test failed on Ubuntu due to a too strict bound in test/Multigrid.jl, I'll loosen that up here and add a seed as well.

@lukem12345 lukem12345 merged commit ff6541d into main Nov 20, 2024
8 of 9 checks passed
@lukem12345 lukem12345 deleted the gr/rm_deps branch November 20, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants