fixed bug where type-checking subtraction uses +(S1,S2), which is obs…

…olete
AlgebraicJulia · Sep 18, 2024 · 87f65fe · 87f65fe
1 parent b9b4146
commit 87f65fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/deca/ThDEC.jl b/src/deca/ThDEC.jl
@@ -195,7 +195,9 @@ end
     end
 end
 
-@operator -(S1, S2)::DECQuantity begin +(S1, S2) end
+@operator -(S1, S2)::DECQuantity begin
+    promote_symtype(+, S1, S2)
+end
 
 @operator *(S1, S2)::DECQuantity begin
     @match (S1, S2) begin

diff --git a/test/decasymbolic.jl b/test/decasymbolic.jl
@@ -13,7 +13,6 @@ u, v = @syms u::PrimalForm{0, :X, 2} du::PrimalForm{1, :X, 2}
 ϕ, ψ = @syms ϕ::PrimalVF{:X, 2} ψ::DualVF{:X, 2}
 # TODO would be nice to pass the space globally to avoid duplication
 
-
 @testset "Term Construction" begin
 
     @test symtype(a) == Scalar
@@ -44,6 +43,8 @@ u, v = @syms u::PrimalForm{0, :X, 2} du::PrimalForm{1, :X, 2}
     @test promote_symtype(+, a, b) == Scalar
     @test promote_symtype(∧, u, u) == PrimalForm{0, :X, 2}
     @test promote_symtype(∧, u, ω) == PrimalForm{1, :X, 2}
+    @test promote_symtype(-, a) == Scalar
+    @test promote_symtype(-, u, u) == PrimalForm{0, :X, 2}
 
     # test composition
     @test promote_symtype(d ∘ d, u) == PrimalForm{2, :X, 2}