Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UART_ADDR constant #29

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Remove UART_ADDR constant #29

merged 5 commits into from
Sep 3, 2024

Conversation

Alignof
Copy link
Owner

@Alignof Alignof commented Sep 3, 2024

  • Remove util.rs.
  • Move print macro to uart.rs.
  • Modify trap_interrupt to use dtb parsed data instead of constant.

@Alignof Alignof self-assigned this Sep 3, 2024
github-actions[bot]
github-actions bot reviewed Sep 3, 2024
View reviewed changes
src/device/uart.rs Outdated Show resolved Hide resolved
src/device/uart.rs Outdated Show resolved Hide resolved
src/device/uart.rs Outdated Show resolved Hide resolved
src/memmap/constant.rs Outdated Show resolved Hide resolved
@Alignof
Copy link
Owner Author

Alignof commented Sep 3, 2024

Memo: Device constants couldn't remove because device tree was not parsed at machine_init.rs

@Alignof Alignof merged commit 3539116 into develop Sep 3, 2024
1 check passed
@Alignof Alignof deleted the refactor/remove_device_constant branch September 3, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Alignof Alignof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Alignof