Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how cached paired planes search for movies. #23

Merged
merged 13 commits into from
Dec 17, 2024

Conversation

arielleleon
Copy link
Collaborator

@arielleleon arielleleon commented Dec 12, 2024

aind-ophys-motion-correction copied the raw h5 file to it's results directory for decrosstalk processing. The pipeline contains a new channel connection from the raw data to decrosstalk so that the file never needs to be copied in the first place. Also added a debug mode.

@arielleleon arielleleon requested a review from jkim0731 December 12, 2024 22:54
@arielleleon arielleleon marked this pull request as draft December 12, 2024 22:54
@arielleleon arielleleon marked this pull request as ready for review December 16, 2024 21:35
Copy link

@mattjdavis mattjdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a helpful debug mode was added, i see no problems

@mattjdavis
Copy link

mattjdavis commented Dec 16, 2024

given that
"oeid" (ophys_experiment_id) is no longer used in CO era, one could relace variables names with "plane_name". just a note we could change in the future, would rather get the PR in

@arielleleon
Copy link
Collaborator Author

@mattjdavis, I put that into an issue: #24

Copy link
Collaborator

@jkim0731 jkim0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Input parameters in some of the functions need to be documented. (e.g., def paired_plane_cached_movie: chunk_size, non_rigid, block_size, return_rframes, etc.)

@arielleleon arielleleon merged commit 6f8885c into main Dec 17, 2024
@arielleleon arielleleon deleted the feature/better-file-searching branch December 17, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants