extracted TODOs into GH issues

AlmasB · Feb 24, 2024 · 862fd8d · 862fd8d
1 parent 96aaafd
commit 862fd8d
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 24 deletions.
diff --git a/fxgl-entity/src/main/kotlin/com/almasb/fxgl/entity/GameWorld.kt b/fxgl-entity/src/main/kotlin/com/almasb/fxgl/entity/GameWorld.kt
@@ -416,8 +416,6 @@ class GameWorld {
         if (pooledEntity != null) {
             pooledEntity.setPosition3D(data.x, data.y, data.z)
 
-            // TODO: also parse data?
-
             return pooledEntity
         }
 

diff --git a/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/inventory/Inventory.kt b/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/inventory/Inventory.kt
@@ -260,7 +260,6 @@ class ItemData<T> internal constructor(var userItem: T) {
     fun nameProperty() = nameProperty
     fun descriptionProperty() = descriptionProperty
 
-    // TODO: make it read-only
     fun quantityProperty() = quantityProperty
 
     var view: Node

diff --git a/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/quest/Quest.kt b/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/quest/Quest.kt
@@ -126,7 +126,6 @@ constructor(
          */
         val description: String,
 
-        // TODO:
         /**
          * How much time is given to complete this objective.
          * Default: 0 - unlimited.

diff --git a/fxgl-intelligence/src/main/kotlin/com/almasb/fxgl/gesturerecog/HandTrackingService.kt b/fxgl-intelligence/src/main/kotlin/com/almasb/fxgl/gesturerecog/HandTrackingService.kt
@@ -18,7 +18,6 @@ import org.openqa.selenium.chrome.ChromeOptions
 import java.util.function.Consumer
 
 /**
- * TODO: remove duplicate code
  *
  * @author Almas Baim (https://github.com/AlmasB)
  */

diff --git a/...ence/src/main/kotlin/com/almasb/fxgl/intelligence/speechrecog/SpeechRecognitionService.kt b/...ence/src/main/kotlin/com/almasb/fxgl/intelligence/speechrecog/SpeechRecognitionService.kt
@@ -43,7 +43,6 @@ class SpeechRecognitionService : WebAPIService(
         setReady()
     }
 
-    // TODO: expand API to also include alternative text options
     private fun onSpeechInput(text: String, confidence: Double) {
         log.debug("Received speech input ($confidence): $text")
 

diff --git a/fxgl-samples/src/main/java/sandbox/joints/DistanceJointSample.java b/fxgl-samples/src/main/java/sandbox/joints/DistanceJointSample.java
@@ -32,9 +32,6 @@
 import static com.almasb.fxgl.dsl.FXGL.*;
 
 /**
- * TODO: a unified physics simulation sample to extend from, which provides
- * ability to shoot a physics projectile and spawn various physics objects.
- *
  *
  * @author Almas Baimagambetov (AlmasB) ([email protected])
  */

diff --git a/fxgl-samples/src/main/java/sandbox/joints/PrismaticJointSample.java b/fxgl-samples/src/main/java/sandbox/joints/PrismaticJointSample.java
@@ -29,9 +29,6 @@
 import static com.almasb.fxgl.dsl.FXGL.*;
 
 /**
- * TODO: a unified physics simulation sample to extend from, which provides
- * ability to shoot a physics projectile and spawn various physics objects.
- *
  * Shows how to use PrismaticJoints with PhysicsComponent.
  *
  * @author Almas Baimagambetov (AlmasB) ([email protected])

diff --git a/fxgl-samples/src/main/java/sandbox/joints/RevoluteJointSample.java b/fxgl-samples/src/main/java/sandbox/joints/RevoluteJointSample.java
@@ -29,9 +29,6 @@
 import static com.almasb.fxgl.dsl.FXGL.*;
 
 /**
- * TODO: a unified physics simulation sample to extend from, which provides
- * ability to shoot a physics projectile and spawn various physics objects.
- *
  * Shows how to use RevoluteJoints with PhysicsComponent.
  *
  * @author Almas Baimagambetov (AlmasB) ([email protected])

diff --git a/fxgl-samples/src/main/java/sandbox/joints/RopeJointSample.java b/fxgl-samples/src/main/java/sandbox/joints/RopeJointSample.java
@@ -27,9 +27,6 @@
 import static com.almasb.fxgl.dsl.FXGL.*;
 
 /**
- * TODO: a unified physics simulation sample to extend from, which provides
- * ability to shoot a physics projectile and spawn various physics objects.
- *
  * Shows how to use RevoluteJoints with PhysicsComponent.
  *
  * @author Almas Baimagambetov (AlmasB) ([email protected])

diff --git a/fxgl-samples/src/main/java/sandbox/joints/RopeJointSample2.java b/fxgl-samples/src/main/java/sandbox/joints/RopeJointSample2.java
@@ -29,9 +29,6 @@
 import static com.almasb.fxgl.dsl.FXGL.*;
 
 /**
- * TODO: a unified physics simulation sample to extend from, which provides
- * ability to shoot a physics projectile and spawn various physics objects.
- *
  * Shows how to use RevoluteJoints with PhysicsComponent.
  *
  * @author Almas Baimagambetov (AlmasB) ([email protected])

diff --git a/fxgl/src/main/kotlin/com/almasb/fxgl/app/MainWindow.kt b/fxgl/src/main/kotlin/com/almasb/fxgl/app/MainWindow.kt
@@ -528,7 +528,6 @@ internal class EmbeddedPaneWindow(
     override val y: Double
         get() = fxglPane.localToScene(0.0, 0.0).y
 
-    // TODO: fix impl
     override val isFocused: Boolean
         get() = true
 

diff --git a/fxgl/src/main/kotlin/com/almasb/fxgl/scene3d/CustomShape3D.kt b/fxgl/src/main/kotlin/com/almasb/fxgl/scene3d/CustomShape3D.kt
@@ -18,8 +18,6 @@ import javafx.scene.shape.TriangleMesh
 import java.util.stream.Collectors
 import java.util.stream.IntStream
 
-// TODO: cache meshes (check CylinderKey)
-
 /**
  *
  * @author Almas Baimagambetov ([email protected])
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ import org.openqa.selenium.chrome.ChromeOptions @@
     import java.util.function.Consumer
     /**
-     * TODO: remove duplicate code
      *
      * @author Almas Baim (https://github.com/AlmasB)
      */
@@ Expand Down @@