Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple evm chains #329

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samparsky
Copy link
Contributor

@samparsky samparsky commented Oct 20, 2020

Fixes #324

Ivshti
Ivshti previously approved these changes Oct 30, 2020
@samparsky samparsky force-pushed the fix/multiple-evm-chain branch from 12e31e8 to b8e65d1 Compare January 19, 2021 09:35
const provider =
ethProvider ||
(depositChainId && new providers.JsonRpcProvider(cfg.supportedChainIdsByRPC[depositChainId])) ||
getDefaultProvider(cfg.ETHEREUM_NETWORK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no ETHEREUM_NETWORK in the cfg - it is NETWORK. In docs/configuration.md it's ETHEREUM_NETWORK - just has to be NETWORK everywhere I guess.

const provider =
ethProvider ||
(depositChainId && new providers.JsonRpcProvider(cfg.supportedChainIdsByRPC[depositChainId])) ||
getDefaultProvider(cfg.ETHEREUM_NETWORK)
Copy link
Member

@ivopaunov ivopaunov Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check cfg.supportedChainIdsByRPC[depositChainId] before new providers.JsonRpcProvider... as at the moment cfg.supportedChainIdsByRPC is empty and I'm not sure if it will throw or use default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow different assets to be on different EVM chains
3 participants