Waiver filtering update [Production] #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix "ValidFrom" and "ValidFrom" (they were swapped) - Move filtering based on the Archive from the server to SOQL query - Add condition "Waiver_Active_End__c >= TODAY" to filter waivers that are not achieved on time - If waiver not found, throw 404 error + return message "No current waiver found"
…d-waivers Waiver filtering update
`Student_Record_Complete__c` is not set to true anymore, but the message was not updated.
…rticipated__c` Add `Year_of_Reference_for_Grade_Information__c` and `Grades_child_participated__c` to GET, PATCH and POST flows: - get:\contacts\(contactId) - get:\contacts - get:\contacts\search - get:\contacts\searchByPhoneNumber - post:\contacts - patch:\contacts\(contactId) Now payload supports: `YearOfReferenceForGradeInformation` and `GradesChildParticipated` as string objects. Use `;` as a seperator for GradesChildParticipated values (for example, "5th;6th").
…student-contact-fields `Year_of_Reference_for_Grade_Information__c` and `Grades_child_participated__c`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #298.
Please do not merge until debug+Sandbox has been verified.
Changes Implemented:
Waiver_Active_End__c >= TODAYin the SOQL query to filter out waivers that haven't met the required timelines.Examples: