Discord Id Check #69
Discord Id Check #69
Conversation
packages/web/src/components/DiscordCheck/DiscordButtonCheck.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/DiscordCheck/DiscordButtonCheck.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/DiscordCheck/DiscordButtonCheck.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/DiscordCheck/DiscordButtonCheck.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
packages/web/tests/components/DiscordCheck/DiscordButtonCheck.test.tsx
Outdated
Show resolved
Hide resolved
| interface User { | ||
| discordId?: string; | ||
| } |
There was a problem hiding this comment.
Is User not defined anywhere else in the front end?
| @@ -0,0 +1,61 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
I just noticed this, but this directory should have the same name as the file; can you rename the parent DiscordÇheck to match DiscordButton?
| @@ -29,7 +29,7 @@ export const UserProfile: React.FC<UserProfileProps> = ({ user, setUser }: UserP | |||
| 'content-type': 'application/json', | |||
| }, | |||
| body: JSON.stringify({ | |||
| discordId: undefined, | |||
| discordId: null, | |||
There was a problem hiding this comment.
Why was this change made? null doesn't match the type above (string in conjunction with ? becomes string | undefined which is not the same as string | null)
There was a problem hiding this comment.
This was made because I don't think the database knows what undefined was. Unless we change it to null the discord ID is not actually removed from the profile. it just selects the profile but doesn't actually remove the Discord ID.
| interface User { | ||
| discordId?: string; | ||
| } |
There was a problem hiding this comment.
We should be using the same type the front end uses; adding our own interface adds no value because if the front end's interface changes, the type safety here won't catch it
| @@ -0,0 +1,61 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
The file name here should match the component exactly; make sure to rename this file and the parent directory
Pre-Requisites
Description of Changes
Check the database to see if the current user has a discordId attached to their profile. If they are registered display the "Go to Discord" button. If not registered display the "Join Discord" button.
Related Issues
Closes #52
Relies on #74