-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it appropriate to some of these options strings into consts for reuse?
e.g. language is used multiple places, should we have a few lines of could like this:
const std::string lang_flags="-l";
const std::string lang_text="Language this object will use."
I feel like most option flags should have both short and long flags. e.g. |
Per face-to-face discussion, this suggested change's positive impact on maintenance remains up for debate. It is NOT a requirement for this PR. |
IMHO it is not necessarily to do for rarely using options. If we dedicate a letter for a rarely using option we close a possibility to use this letter for an option which may be added in the future and will be used more often. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about default value for init
subcommand.
Some --help
examples need to be updated.
Man page has a couple lines that should be deleted.
EDIT: fixed now.
Interesting point! I'm not opposed to this BUT it is significant extra work to remove those now. EDIT: nothing needs to be done here. |
The following help examples remain incorrect:
Additionally the following have path and should not:
|
Please consider updating init's path option, current wording is somewhat unclear.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
resolves #13