-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Add more extensive tests for finalizer voting behavior #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed `block_state.hpp`.
…se it is types containing these.
Note:start |
heifner
requested changes
Mar 1, 2024
linh2931
reviewed
Mar 1, 2024
heifner
reviewed
Mar 1, 2024
heifner
approved these changes
Mar 1, 2024
linh2931
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2233.
This PR adds some unit test for finalizer voting that validate correct checks for monotony, liveness and safety.
It also adds to stream output functions for some types used by the finalizer, which allows to use these types in
BOOST_ASSERT_EQUAL
macros which provide better output when they fail thanBOOST_ASSERT
.It also adds spaceship operator comparisons to some fc types (including
sha256
) andblock_timestamp
, which allows to define default spaceship comparison operators in new types containing these (as is the case forblock_ref
).