Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Add more extensive tests for finalizer voting behavior #2272

Merged
merged 21 commits into from
Mar 1, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Feb 29, 2024

Resolves #2233.

This PR adds some unit test for finalizer voting that validate correct checks for monotony, liveness and safety.

It also adds to stream output functions for some types used by the finalizer, which allows to use these types in BOOST_ASSERT_EQUAL macros which provide better output when they fail than BOOST_ASSERT.

It also adds spaceship operator comparisons to some fc types (including sha256) and block_timestamp, which allows to define default spaceship comparison operators in new types containing these (as is the case for block_ref).

@greg7mdp greg7mdp changed the base branch from main to hotstuff_integration February 29, 2024 18:55
@greg7mdp greg7mdp requested review from heifner and linh2931 February 29, 2024 19:22
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Adds unit test for finalizer voting that validate correct checks for monotony, liveness and safety. Adds support for adds spaceship operator comparisons to some fc types, and support for BOOST_ASSERT_EQUAL to some types used by finalizer.
Note:end

@greg7mdp greg7mdp merged commit 49c96a2 into hotstuff_integration Mar 1, 2024
26 checks passed
@greg7mdp greg7mdp deleted the gh_2233 branch March 1, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Add more extensive tests for finalizer voting behavior
4 participants