IF: Add new snapshot version to hold consensus hotstuff state #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Mar 9, 2024
heifner
reviewed
Mar 9, 2024
heifner
reviewed
Mar 9, 2024
heifner
approved these changes
Mar 9, 2024
|
Note:start |
Snapshot conversion to json was crashing because forkdb `head` was empty.
It is nicer to have them printed before `index` in `gdb`
linh2931
approved these changes
Mar 11, 2024
| .activated_protocol_features = std::move(sbs.activated_protocol_features), | ||
| .core = std::move(sbs.core), | ||
| .proposal_mtree = std::move(sbs.proposal_mtree), | ||
| .finality_mtree = std::move(sbs.finality_mtree), |
| // 4. edit `unittests/snapshots/CMakeLists.txt` and add the `configure_file` commands for the 3 new files. | ||
| // now the test should pass. | ||
| // 5. add the 3 new snapshot files in git. | ||
| // ------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Great to have this instruction!
| @@ -150,8 +150,9 @@ set_property(TEST ship_if_test PROPERTY LABELS nonparallelizable_tests) | |||
|
|
|||
| add_test(NAME ship_streamer_test COMMAND tests/ship_streamer_test.py -v --num-clients 10 ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR}) | |||
| set_property(TEST ship_streamer_test PROPERTY LABELS long_running_tests) | |||
| add_test(NAME ship_streamer_if_test COMMAND tests/ship_streamer_test.py -v --num-clients 10 --activate-if ${UNSHARE} WORKING_DIRECTORY ${CMAKE_BINARY_DIR}) | |||
| set_property(TEST ship_streamer_if_test PROPERTY LABELS long_running_tests) | |||
| # uncomment after https://github.com/AntelopeIO/leap/issues/2285 implemented | |||
There was a problem hiding this comment.
Add a note in 2285 to uncomment this so we won't forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1558.
Add new snapshot version (V7) to support storing the new
chain_head, which can be either ablock_state_legacy(pre IF transition) or ablock_state(post IF transition).