Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenomics - Vesting upgrade #81

Merged
merged 14 commits into from
May 13, 2024
Merged

Tokenomics - Vesting upgrade #81

merged 14 commits into from
May 13, 2024

Conversation

DenisCarriere
Copy link
Member

@DenisCarriere DenisCarriere commented May 3, 2024 •
edited
Loading

@DenisCarriere DenisCarriere requested a review from nsjames May 3, 2024 21:12
@DenisCarriere DenisCarriere marked this pull request as ready for review May 3, 2024 21:17
@nsjames
Copy link
Contributor

nsjames commented May 10, 2024

@DenisCarriere this looks good, need your final uno reverse review on the changes and then we can merge it in

@DenisCarriere
Copy link
Member Author

DenisCarriere commented May 10, 2024 •
edited
Loading

Sounds good, we will just need to define the new action "setpayfactor" in an issue or the PR's documentation, I can update that.

✅ added docs for setpayfactor in eosnetworkfoundation/eos-system-contracts#136

DenisCarriere
DenisCarriere commented May 10, 2024
View reviewed changes
Copy link
Member Author

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to merge, only a few comments on some areas, no blockers

contracts/eosio.system/src/eosio.system.cpp Show resolved Hide resolved
contracts/eosio.system/src/eosio.system.cpp Show resolved Hide resolved
@nsjames nsjames merged commit 046f5a0 into tokenomics May 13, 2024
1 check passed
@nsjames nsjames deleted the tokenomics-vesting-upgrade branch May 13, 2024 11:38
@nsjames nsjames mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsjames nsjames nsjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisCarriere @nsjames