Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Make test more generic to work with diff versions of instant_finality_extension #82

Merged
merged 1 commit into from
May 8, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 8, 2024

Change Description

Modify test to allow for different formats of instant_finality_extension.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner requested review from linh2931 and greg7mdp May 8, 2024 01:19
@heifner heifner added the OCI label May 8, 2024
Copy link

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad that variant doesn't have a recursive find, seems that it would be nicer than having to convert to a string.

tests/eosio.bios_inst_fin_tests.cpp Show resolved Hide resolved
@heifner heifner merged commit cd645b5 into main May 8, 2024
1 check passed
@heifner heifner deleted the more-generic-test branch May 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants