GH-985 Better logging for interrupted apply_block trx

AntelopeIO · Oct 31, 2024 · 078781a · 078781a
1 parent d0ea755
commit 078781a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/libraries/chain/controller.cpp b/libraries/chain/controller.cpp
@@ -3813,7 +3813,7 @@ struct controller_impl {
 
                if( transaction_failed && !transaction_can_fail) {
                   if (trace->except->code() == interrupt_exception::code_value) {
-                     ilog("Interrupt of trx: ${t}", ("t", *trace));
+                     ilog("Interrupt of trx id: ${id}", ("id", trace->id));
                   } else {
                      edump((*trace));
                   }
@@ -4370,7 +4370,15 @@ struct controller_impl {
          log_irreversible();
          transition_to_savanna_if_needed();
          return controller::apply_blocks_result::complete;
-      } FC_LOG_AND_RETHROW( )
+      } catch (fc::exception& e) {
+         if (e.code() != interrupt_exception::code_value) {
+            wlog("${d}", ("d",e.to_detail_string()));
+            FC_RETHROW_EXCEPTION(e, warn, "rethrow");
+         }
+         throw;
+      } catch (...) {
+         try { throw; } FC_LOG_AND_RETHROW()
+      }
    }
 
    controller::apply_blocks_result maybe_apply_blocks( const forked_callback_t& forked_cb, const trx_meta_cache_lookup& trx_lookup )