Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: transition_to_if #1082

Closed
heifner opened this issue Dec 19, 2024 · 0 comments · Fixed by #1086
Closed

Test failure: transition_to_if #1082

heifner opened this issue Dec 19, 2024 · 0 comments · Fixed by #1086
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.1.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Dec 19, 2024

https://github.com/AntelopeIO/spring/actions/runs/12413237954/job/34655392902

  File "/__w/spring/spring/build/tests/transition_to_if.py", line 82, in <module>
    assert cluster.getNode(irreversibleNodeId).waitForLibToAdvance(), f"Lib stopped advancing on Node {irreversibleNodeId}, irreversible node"
AssertionError: Lib stopped advancing on Node 4, irreversible node
@heifner heifner self-assigned this Dec 19, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Dec 19, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 19, 2024
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Dec 19, 2024
@bhazzard bhazzard added bug The product is not working as was intended. and removed triage labels Dec 19, 2024
heifner added a commit that referenced this issue Dec 20, 2024
@heifner
GH-1082 Handle interrupt in irreversible mode. Return apply_blocks re…
3034775 
…sult in irreversible mode so incomplete apply is handled correctly.
@heifner heifner mentioned this issue Dec 20, 2024
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Dec 20, 2024
heifner added a commit that referenced this issue Dec 20, 2024
@heifner
GH-1082 Limit apply_blocks in irreversible mode to 500ms similar to a…
2c0ca2e 
…pply_blocks in non-irreversible mode.
heifner added a commit that referenced this issue Dec 20, 2024
@heifner
GH-1082 Must break after completion of making block irreversible
a19ff61
heifner added a commit that referenced this issue Dec 21, 2024
@heifner
Merge pull request #1086 from AntelopeIO/GH-1082-irreversible
48983b4 
Irreversible mode improvements
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

Irreversible mode improvements AntelopeIO/spring
3 participants
@bhazzard @heifner @enf-ci-bot