Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irreversible mode improvements #1086

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Irreversible mode improvements #1086

merged 3 commits into from
Dec 21, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 20, 2024

  • Return apply_blocks result in irreversible mode so incomplete apply is handled correctly.
  • Handle interrupt in irreversible mode without logging an error.

Test failed because irreversible mode nodeos would not transition to Savanna. It would not transition because the log_irreversible was incomplete but nothing called apply_blocks again to continue the process.

Resolves #1082

…sult in irreversible mode so incomplete apply is handled correctly.
@heifner heifner added the OCI Work exclusive to OCI team label Dec 20, 2024
@heifner heifner requested review from linh2931 and greg7mdp December 20, 2024 15:11
Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this would have been equivalent to leaving the check in should_process, setting result to incomplete before entering the loop, not updating it within the loop, and setting it to complete after the loop if the iterator is at end().

@heifner
Copy link
Member Author

heifner commented Dec 21, 2024

I think that this would have been equivalent to leaving the check in should_process, setting result to incomplete before entering the loop, not updating it within the loop, and setting it to complete after the loop if the iterator is at end().

If you think that is clearer, I can change it.

@greg7mdp
Copy link
Contributor

If you think that is clearer, I can change it.

Up to you what you think is best since you are the one maintaining this code generally. I'm fine either way.

@heifner heifner merged commit 48983b4 into main Dec 21, 2024
36 checks passed
@heifner heifner deleted the GH-1082-irreversible branch December 21, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: transition_to_if
3 participants