Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: distributed-transactions-if-test #848

Closed
heifner opened this issue Oct 1, 2024 · 2 comments · Fixed by #908 or #910
Closed

Test failure: distributed-transactions-if-test #848

heifner opened this issue Oct 1, 2024 · 2 comments · Fixed by #908 or #910
Assignees
Labels
👍 lgtm test-bug A test is not working as was intended. test-instability tag issues for flaky tests, high priority to address
Milestone

Comments

@heifner
Copy link
Member

heifner commented Oct 1, 2024

https://github.com/AntelopeIO/spring/actions/runs/11125907838/job/30915459664

Duplicate Staring block found: 100 in /__w/spring/spring/build/TestLogs/distributed-transactions-test8/node_bios/stderr.2024_10_01_13_21_16.txt

Received block 100 late so it restarted speculative block 100. This is expected behavior, so not really sure what we want to do with this. The check was added to guard agaisnt a bug where a block was restarted when it was not suppose to be. Maybe the test should look at the timestamps and only fail if the start block is within some threshold.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Oct 1, 2024
@heifner heifner added the test-instability tag issues for flaky tests, high priority to address label Oct 1, 2024
@arhag
Copy link
Member

arhag commented Oct 2, 2024

We can update the test to only fail if a block number is repeated with the same timestamp. It should tolerate repeating a speculative block with a higher timestamp.

@arhag arhag added 👍 lgtm test-bug A test is not working as was intended. and removed triage labels Oct 2, 2024
@arhag arhag added this to the Spring v1.0.3 milestone Oct 2, 2024
@greg7mdp greg7mdp self-assigned this Oct 7, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Oct 7, 2024
@heifner
Copy link
Member Author

heifner commented Oct 7, 2024

build\TestLogs\distributed-transactions-test8\node_bios\stderr.2024_10_01_13_21_16.txt

debug 2024-10-01T13:22:05.393 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.000 producer defproducerc, deadline 2024-10-01T13:22:05.962
debug 2024-10-01T13:22:06.025 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.500 producer defproducerc, deadline 2024-10-01T13:22:06.525
debug 2024-10-01T13:22:06.503 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:07.000 producer defproducerc, deadline 2024-10-01T13:22:07.003

Lines 9643, 9783, 9818

Note the timestamps are different, so the test should not fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm test-bug A test is not working as was intended. test-instability tag issues for flaky tests, high priority to address
Projects
Status: Done
4 participants