[1.0.3] Test failure: distributed-transactions-if-test

[greg7mdp]

Resolves #848.

This updates the verifyStartingBlockMessages check in Node.py to check that we have only one Starting block in the log for any block number unless:

1. the block was restarted because it was exhausted,
2. or the second Starting block is for a different block time than the first.

I have checked the new regular expression with a small python script against the log and it appears to work fine.

script:

import re

def check_file_for_pattern(file_path, pattern):
    regex = re.compile(pattern)

    with open(file_path, 'r') as file:
        for line_num, line in enumerate(file, start=1):
            match = regex.match(line)
            if match:
                blockNumber, time = match.group(1), match.group(2)
                print(f"{blockNumber} -> {time}")

if __name__ == "__main__":
    file_path = "stderr.2024_10_01_13_21_16.txt"
    pattern = r".*Starting block #(\d+) .*(\d\d:\d\d\.\d\d\d) producer"
    check_file_for_pattern(file_path, pattern)

execution:

❯ python ~/tmp/check_regexp.py
2 -> 21:17.000
3 -> 21:17.500
4 -> 21:18.000
5 -> 21:18.500
6 -> 21:19.000
7 -> 21:19.500
8 -> 21:20.000
9 -> 21:20.500
10 -> 21:21.000
...

[heifner]

2. or the second Starting block is for the exact same block time as the first

This should be: "2. or the second Starting block is for a different block time than the first."

[greg7mdp]

This should be: "2. or the second Starting block is for a different block time than the first."

I don't think so. The full sentence is:

we should have only one Starting block in the log for any block number unless the second Starting block is for the exact same block time as the first.

[heifner]

we should have only Starting block in the log for any block number unless the second Starting block is for the exact same block time as the first.

It is actually the opposite of that.

This should be allowed:

debug 2024-10-01T13:22:05.393 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.000 producer defproducerc, deadline 2024-10-01T13:22:05.962
debug 2024-10-01T13:22:06.025 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.500 producer defproducerc, deadline 2024-10-01T13:22:06.525

This should not be allowed:

debug 2024-10-01T13:22:05.393 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.000 producer defproducerc, deadline 2024-10-01T13:22:05.962
debug 2024-10-01T13:22:06.025 nodeos    producer_plugin.cpp:2165      start_block          ] Starting block #100 2024-10-01T13:22:06.000 producer defproducerc, deadline 2024-10-01T13:22:06.525

[greg7mdp]

Thanks @heifner good catch!

[ericpassmore]

Note:start
category: Tests
component: Internal
summary: Improve python test harness to better support distributed transactions tests.
Note:end