Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC Whitelist: ctrl-c interrupt of executing trx #985

Closed
Tracked by #888
bhazzard opened this issue Oct 29, 2024 · 1 comment · Fixed by #993
Closed
Tracked by #888

OC Whitelist: ctrl-c interrupt of executing trx #985

bhazzard opened this issue Oct 29, 2024 · 1 comment · Fixed by #993
Assignees
@heifner
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.1.0-rc1

Comments

@bhazzard
Copy link

Add ctrl-c interrupt of executing trx. Execute queued compiles up to some limit (maybe 10 seconds) before exiting. On restart the contract would be compiled with oc and the block should be able to be validated.
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Oct 29, 2024
@bhazzard bhazzard mentioned this issue Oct 29, 2024
Closed
@bhazzard bhazzard removed the triage label Oct 29, 2024
@heifner heifner self-assigned this Oct 30, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 30, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 30, 2024
@heifner
Copy link
Member

heifner commented Oct 30, 2024

Depends on #876

@heifner heifner mentioned this issue Oct 30, 2024
Closed
heifner added a commit that referenced this issue Oct 30, 2024
@heifner
GH-985 Add ability to interrupt transaction in apply_block
73120f5
heifner added a commit that referenced this issue Oct 30, 2024
@heifner
GH-985 Add unittest for interrupt_transaction
2ff14e7
heifner added a commit that referenced this issue Oct 30, 2024
@heifner
GH-985 Add integration test for interrupt_transaction
a21cf18
@heifner heifner mentioned this issue Oct 30, 2024
Merged
heifner added a commit that referenced this issue Oct 31, 2024
@heifner
GH-985 Better logic for determining if deadline timer was because of …
ecf2d0a 
…interrupt
heifner added a commit that referenced this issue Oct 31, 2024
@heifner
GH-985 Avoid multiple expiration callback calls.
d0ea755
heifner added a commit that referenced this issue Oct 31, 2024
@heifner
GH-985 Better logging for interrupted apply_block trx
078781a
heifner added a commit that referenced this issue Nov 1, 2024
@heifner
GH-985 Update test now that appbase supports interrupt off main thread
f8f327c
heifner added a commit that referenced this issue Nov 1, 2024
@heifner
GH-985 chain is not available until after initialize
8012d03
heifner added a commit that referenced this issue Nov 1, 2024
@heifner
GH-985 Remove duplicate code
bb4d159
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Nov 4, 2024
heifner added a commit that referenced this issue Nov 6, 2024
@heifner
Merge pull request #993 from AntelopeIO/GH-985-interrupt-trx
cf7c6e8 
Support interrupt transaction
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Nov 6, 2024
heifner added a commit that referenced this issue Nov 8, 2024
@heifner
GH-985 For an interrupt exception do not remove block from fork db
5c4a35a
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985 Remove block from forkdb on interrupt if it has been running l…
0b3825d 
…onger than 2 block intervals
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985 Cleanup interrupt test
af67e0d
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
Merge branch 'main' into GH-985-interrupt-apply
c7b42ad
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985 Move push_trx to test_utils
29ac711
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985
9a6c881 
- Add callback for when async compile completes
  - Use to kill action if it is still running in non-oc
- Kick off another queued compile when compile finishes
- Add executing_action_id and queued_time to oc compile ipc_protocol
- Pause billing timer when looking up and processing oc code
- Move wasm_interface apply function to wasm_interface_impl
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985 Add ability to retroactively pause timer when resuming billing…
01c0ebd 
… timer. Cleanup transaction_timer so that its deadline matches _deadline of transaction_context
heifner added a commit that referenced this issue Nov 11, 2024
@heifner
GH-985 Add wasm interrupt test by oc compile
aabcfb4
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 3 seconds not long enough on ci/cd
d19d718
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Remove accidental add of ${i}
b73fbc5
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Pass io_context to compile callback so it can use it to create…
49198a0 
… a timer
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Add interrupt_oc_exception
2875ed9
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Restart transaction instead of action since transaction side e…
2b56de1 
…ffects have to be undone.
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 compiler needs explicit construction of microseconds since con…
39af386 
…structor is explicit
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Update test now that id is only updated once per action call
6a126e7
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Increase to 10s for ci/cd
78761e6
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Try increase to 30s for ci/cd
c05bc48
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Remove unneeded chain::wasm_interface::test_disable_tierup.
76e2cc7
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Reset transaction_context on oc interrupt
d77773e
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Try a full minute
16c13e4
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Test with output
0b63326
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Try 75s
2619f9e
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Correctly monitor outstanding compiles
98b3061
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Fix FC_ASSERT on exit when socket closed
46ca22d
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Correctly monitor outstanding compiles
d8017a7
heifner added a commit that referenced this issue Nov 12, 2024
@heifner
GH-985 Fix FC_ASSERT on exit when socket closed
5b2c116
heifner added a commit that referenced this issue Nov 13, 2024
@heifner
Merge pull request #1021 from AntelopeIO/GH-985-interrupt-apply
88c8dbe 
Do not unwind validated blocks on interrupt
@heifner heifner added the enhancement New feature or request label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

Support interrupt transaction AntelopeIO/spring
3 participants
@bhazzard @heifner @enf-ci-bot