Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Savanna IBC tests improvements #136

Merged
merged 24 commits into from
May 17, 2024
Merged

Savanna IBC tests improvements #136

merged 24 commits into from
May 17, 2024

Conversation

systemzax
Copy link
Member

@systemzax systemzax commented May 13, 2024 •
edited
Loading

Includes :

  1. testing of action proofs
  2. testing of finalizer policy change proofs, as well as testing of finality proofs with the newly changed finalizer policy generation

Addresses the following issues :

#119
#134

systemzax added 13 commits May 8, 2024 12:14
@systemzax
refactored svnn_ibc_tests in prepartion for finalizer policy change test
b6a4e45
@systemzax
Restructured svnn_ibc test
6e3b26e
@systemzax
Updated svnn_ibc test to match new finalizer policy diffs
1133abd
@systemzax
Updated to reflect updated finality digest computation + added test f…
006e17e 
…or verification of last pending finalizer policy commitment
@systemzax
Completed new finalizer policy proof
74e584a
@systemzax
Re-enabled cache + garbage collection test
da7f956
@systemzax
Added savanna_witness_hash() intermediate digest function to action t…
60b5998 
…races, completed action proofs test in svnn_ibc
@systemzax
Cleaned up ibc smart contract code
c10f180
@systemzax
Cleaned up ibc smart contract code
16c68f3
@systemzax
Minor edit to comment + removed extra lines
945c802
@systemzax
Removed print statements in contract, recompiled
e8cdafc
@systemzax
Merge branch 'main' into svnn_ibc_tests_improvements
ac55e2d
@systemzax
Merge branch 'main' of https://github.com/antelopeIO/spring
3d794dd
@systemzax systemzax changed the title Svnn ibc tests improvements Savanna IBC tests improvements May 13, 2024
This was linked to issues May 15, 2024
Correction to how Savanna action digest is computed #134
Closed
Extend Savanna IBC unit test to include one (or more) finalizer policy change. #119
Closed
@arhag arhag requested review from heifner and linh2931 May 15, 2024 20:53
heifner
heifner approved these changes May 16, 2024
View reviewed changes
unittests/svnn_ibc_tests.cpp Outdated Show resolved Hide resolved
unittests/svnn_ibc_tests.cpp Outdated Show resolved Hide resolved
unittests/svnn_ibc_tests.cpp Show resolved Hide resolved
unittests/svnn_ibc_tests.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Testing for IBC action proofs, and finalizer policy change proofs
Note:end

@systemzax systemzax merged commit 09b2331 into main May 17, 2024
36 checks passed
@systemzax systemzax deleted the svnn_ibc_tests_improvements branch May 17, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp left review comments

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@systemzax @ericpassmore @greg7mdp @heifner @linh2931