Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main] SHiP: Fix hang on shutdown #820

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 24, 2024

state_history_plugin (SHiP) would sometimes hang on shutdown. The nodeos process would get stuck trying to lock a mutex of the main application io_context strand while destroying a boost::beast::websocket::stream.

Created a test that reproduces the failure (thanks @taokayan for #813). The failure was not reliably repeatable, but it did fail on every CI/CD run for at least one of the platforms. See for example: https://github.com/AntelopeIO/spring/actions/runs/11017331583/job/30595880305

Modified SHiP boost::beast::websocket to use the SHiP thread instead of the main application thread executor strand.

Merges release/1.0 into main including #816.

Resolves #815

@heifner heifner added the OCI Work exclusive to OCI team label Sep 24, 2024
@heifner heifner merged commit a843833 into main Sep 24, 2024
36 checks passed
@heifner heifner deleted the GH-815-ship-hang-fix-main branch September 24, 2024 21:02
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Sep 25, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: SHiP
summary: Fix hang on shutdown.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHiP hang on exit
4 participants