Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Fluent UI to 8.118.2 #222

Merged
merged 8 commits into from
May 16, 2024
Merged

Upgrade Fluent UI to 8.118.2 #222

merged 8 commits into from
May 16, 2024

Conversation

jakubsob
Copy link
Contributor

@jakubsob jakubsob commented May 10, 2024 •
edited
Loading

Changes

  • Upgrade @fluentui/react to 8.118.2.
  • Upgraded Cypress to 13.8.1 and all other JS dependencies to newest versions.
  • Fixed ComboBox component after the upgrade.
  • Refactored selectors and chains in Cypress tests according to Cypress linter.
  • Changed webpack configuration to resolve import/no-unresolved eslint errors.

Important

Remove "Install shiny.react with React 18.3.1" step from CI before merging.

@jakubsob jakubsob force-pushed the upgrade-react branch 15 times, most recently from 7f0366e to 06b833e Compare May 10, 2024 13:06
@jakubsob jakubsob marked this pull request as ready for review May 13, 2024 08:03
@jakubsob jakubsob requested a review from jakubnowicki May 13, 2024 08:03
@jakubsob jakubsob changed the title Upgrade React to 18.3.1 Upgrade Fluent UI to 8.118.2 May 13, 2024
@jakubsob jakubsob self-assigned this May 13, 2024
jakubnowicki
jakubnowicki approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works fine!

DESCRIPTION Show resolved Hide resolved
@jakubsob jakubsob merged commit 36b4d55 into main May 16, 2024
1 check passed
@jakubsob jakubsob deleted the upgrade-react branch May 16, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees

@jakubsob jakubsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubsob @jakubnowicki