Lint all toolkits #183
Lint all toolkits #183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| with: | ||
| python-version: '3.12' | ||
| cache: 'pip' | ||
|
|
There was a problem hiding this comment.
@sdreyer I removed the pip install ./arcade step since all of the toolkits installed the most recent version of arcade-ai
| @@ -234,6 +234,10 @@ class ToolContext(BaseModel): | |||
| user_id: str | None = None | |||
| """The user ID for the tool invocation (if any).""" | |||
|
|
|||
| def get_auth_token_or_empty(self) -> str: | |||
There was a problem hiding this comment.
this will be a tool developer QOL improvement. I can't use them in the toolkits today since arcade-ai and toolkits are no longer released on the same schedule, but after the next arcade-ai release I will update the toolkits to use this. For now, you will see a lot of the following the toolkits: context.authorization.token if context.authorization and context.authorization.token else ""
| ] | ||
|
|
||
| [lint.per-file-ignores] | ||
| "*" = ["TRY003", "B904"] |
There was a problem hiding this comment.
I decided to exclude these two from the linter. Both like to complain whenever RetryableToolError is used. It seemed like a bad experience to need to # noqa: B904 and # noqa: TRY003 whenever the RetryableToolError was used in code.
PR Description
.pre-commit-config.yaml.ruff.tomlLICENSEMakefilepyproject.tomlmake checkandmake test(a total doozy). This includes adding some unit tests and evals.arcade newtemplate.