Add generic overload for GetSlotData in DataStorageWrapper #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some consideration I felt this was the only sane option that didn't involve major API breaks, so as discussed, I added generic overloads for GetSlotData and GetSlotDataAsync, which the DIctionary<string, object> versions now route through. I also happened to notice some cleanup opportunity in the csproj which you can feel free to reject if you don't like it (but I think you will).
Added a new unit test to sanity test deser behavior for custom models, but only added the one since the Dictionary one runs through them so we know the fundamental behavior is still correct, since the old tests still pass.
Did not test on .net 6/System.Text.Json since the tests don't test that framework, and I don't have any games to test it on.