Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ports from 3333 -> 4040 #43

Merged
merged 1 commit into from
Feb 28, 2024
+5 −5
Merged

chore: update ports from 3333 -> 4040 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/world/cardinal/dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

const (
CardinalPort = "3333"
CardinalPort = "4040"
RedisPort = "6379"

// flagWatch : Flag for hot reload support
Expand Down
6 changes: 3 additions & 3 deletions cmd/world/root/root_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type healthResponse struct {
func getHealthCheck() (*healthResponse, error) {
var healtCheck healthResponse

resp, err := http.Get("http://127.0.0.1:3333/health")
resp, err := http.Get("http://127.0.0.1:4040/health")
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -184,7 +184,7 @@ func TestCreateStartStopRestartPurge(t *testing.T) {
// Check cardinal health (expected error)
_, err = getHealthCheck()
assert.Error(t, err,
"Get \"http://127.0.0.1:3333/health\": dial tcp 127.0.0.1:3333: connect: connection refused")
"Get \"http://127.0.0.1:4040/health\": dial tcp 127.0.0.1:4040: connect: connection refused")
}

func TestDev(t *testing.T) {
Expand Down Expand Up @@ -249,5 +249,5 @@ func TestDev(t *testing.T) {
}

assert.Error(t, err,
"Get \"http://127.0.0.1:3333/health\": dial tcp 127.0.0.1:3333: connect: connection refused")
"Get \"http://127.0.0.1:4040/health\": dial tcp 127.0.0.1:4040: connect: connection refused")
}
2 changes: 1 addition & 1 deletion common/tea_cmd/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
env = append(env, k+"="+v)
}
if cfg.Debug {
env = append(env, "CARDINAL_ADDR=cardinal-debug:3333")
env = append(env, "CARDINAL_ADDR=cardinal-debug:4040")

Check warning on line 43 in common/tea_cmd/docker.go

View check run for this annotation

Codecov / codecov/patch

common/tea_cmd/docker.go#L43 

Added line #L43 was not covered by tests
}

cmd.Env = env
Expand Down
Loading