fix: container log, parallel execution, code dupe and process stuck

[zulkhair]

Closes: WORLD-1173

Overview

Fix some PR review bug and changes :

• Fixing stuck on world cardinal dev command if docker container is not running
• Adjust creating/starting/stopping indicator on world cli
• Make stopping container parallel instead of one by one
• Remove extra letter on container log

Brief Changelog

• Add context cancelation when checking redis is healthy to fix stuck on world cardinal dev
• Add multispinner component to handle process animation and concurrent process / parallel
• Removing first escape ANSI character on container log

Testing and Verifying

• Adjusted unit test
• Manual Test

🎥 Video uploaded on Graphite:

🎥 Video uploaded on Graphite:

🎥 Video uploaded on Graphite:

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zulkhair]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: container log, parallel execution, code dupe and process stuck #76 👈
• fix: docker api parallel exec, git config, wrong dir cardinal editor #74 : 1 other dependent PR (#75 )
• feat: change docker compose using docker api sdk #72 : 1 other dependent PR (#73 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 51.90678% with 227 lines in your changes missing coverage. Please review.

Project coverage is 47.48%. Comparing base (096d3c4) to head (ca1e9dd).
Report is 1 commits behind head on graphite-base/76.

Files with missing lines	Patch %	Lines
common/docker/client_image.go	5.66%	99 Missing and 1 partial ⚠️
common/docker/client_volume.go	49.00%	43 Missing and 8 partials ⚠️
common/docker/client_network.go	50.98%	21 Missing and 4 partials ⚠️
common/docker/client_container.go	73.86%	16 Missing and 7 partials ⚠️
common/docker/client.go	66.66%	6 Missing and 4 partials ⚠️
cmd/world/cardinal/dev.go	58.82%	4 Missing and 3 partials ⚠️
tea/style/util.go	28.57%	5 Missing ⚠️
tea/component/multispinner/multispinner.go	93.84%	3 Missing and 1 partial ⚠️
cmd/world/evm/start.go	66.66%	0 Missing and 1 partial ⚠️
cmd/world/evm/stop.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           graphite-base/76      #76      +/-   ##
====================================================
- Coverage             47.58%   47.48%   -0.10%     
====================================================
  Files                    52       54       +2     
  Lines                  2360     2668     +308     
====================================================
+ Hits                   1123     1267     +144     
- Misses                 1039     1190     +151     
- Partials                198      211      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[ellipsis-dev]

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at [email protected]

[zulkhair]

this PR moved to #74