ci: add typecheck step

.github/workflows/nodejs.yml

@@ -28,6 +28,9 @@ jobs:
       - name: Build
         run: pnpm build
 
+      - name: Typecheck
+        run: pnpm typecheck
+
       - name: Lint
         run: pnpm lint
 

package.json

@@ -39,7 +39,8 @@
     "dev": "tsup --watch",
     "build": "tsup",
     "publish": "clean-publish",
-    "lint": "eslint --max-warnings=0"
+    "lint": "eslint --max-warnings=0",
+    "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
     "@types/node": "^20.12.8",

test/move.test.ts

@@ -6,7 +6,8 @@ import { fileURLToPath } from 'node:url'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-const { transferableSymbol, valueSymbol } = Tinypool
+const transferableSymbol = Tinypool.transferableSymbol as never
+const valueSymbol = Tinypool.valueSymbol as never
 
 test('Marking an object as movable works as expected', async () => {
   const obj: any = {
@@ -24,7 +25,7 @@ test('Marking an object as movable works as expected', async () => {
 })
 
 test('Marking primitives and null works as expected', async () => {
-  expect(Tinypool.move(null)).toBe(null)
+  expect(Tinypool.move(null!)).toBe(null)
   expect(Tinypool.move(1 as any)).toBe(1)
   expect(Tinypool.move(false as any)).toBe(false)
   expect(Tinypool.move('test' as any)).toBe('test')
@@ -66,8 +67,10 @@ test('Using MessagePort works as expected', async () => {
   const mc = new MessageChannel()
   const movable = Tinypool.move(mc.port1)
   expect(isMovable(movable)).toBe(true)
-  expect(movable[valueSymbol] instanceof MessagePort).toBe(true)
-  expect(movable[transferableSymbol] instanceof MessagePort).toBe(true)
+  expect((movable[valueSymbol] as unknown) instanceof MessagePort).toBe(true)
+  expect((movable[transferableSymbol] as unknown) instanceof MessagePort).toBe(
+    true
+  )
   expect(movable[transferableSymbol]).toEqual(mc.port1)
 })
 

test/task-queue.test.ts

@@ -201,7 +201,7 @@ test('tasks can share a Worker if requested (both tests finish)', async () => {
   const buffers = [
     new Int32Array(new SharedArrayBuffer(4)),
     new Int32Array(new SharedArrayBuffer(4)),
-  ]
+  ] as const
 
   expect(pool.threads.length).toBe(1)
   expect(pool.queueSize).toBe(0)
@@ -254,8 +254,10 @@ test('custom task queue works', async () => {
 
       expect(Tinypool.queueOptionsSymbol in task).toBeTruthy()
       if ((task as any).task.a === 3) {
+        // @ts-expect-error -- intentional
         expect(task[Tinypool.queueOptionsSymbol]).toBeNull()
       } else {
+        // @ts-expect-error -- intentional
         expect(task[Tinypool.queueOptionsSymbol].option).toEqual(
           (task as any).task.a
         )
@@ -266,6 +268,8 @@ test('custom task queue works', async () => {
       const index = this.tasks.indexOf(task)
       this.tasks.splice(index, 1)
     }
+
+    cancel() {}
   }
 
   const pool = new Tinypool({
@@ -276,7 +280,7 @@ test('custom task queue works', async () => {
     minThreads: 1,
   })
 
-  function makeTask(task, option) {
+  function makeTask(task: any, option: any) {
     return { ...task, [Tinypool.queueOptionsSymbol]: { option } }
   }
 

test/uncaught-exception-from-handler.test.ts

@@ -46,10 +46,10 @@ test('uncaught exception in immediate after task yields error event', async () =
 
   // Hack a bit to make sure we get the 'exit'/'error' events.
   expect(pool.threads.length).toBe(1)
-  pool.threads[0].ref()
+  pool.threads[0]!.ref?.()
 
   // This is the main aassertion here.
-  expect((await errorEvent)[0].message).toEqual('not_caught')
+  expect((await errorEvent)[0]!.message).toEqual('not_caught')
 })
 
 test('using parentPort is treated as an error', async () => {