Add klipper_estimator support #914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsongraca
force-pushed
the
master
branch
3 times, most recently
from
b668132 to
f6c8856
Compare
…mator Signed-off-by: Nelson Graça <[email protected]>
ecsv
added a commit
to ecsv/qidi_x-max_klipper
that referenced
this pull request
Nov 3, 2024
The moonraker component was downloaded from Arksine/moonraker#914 and the estimator from https://github.com/Annex-Engineering/klipper_estimator/releases/download/v3.7.3/klipper_estimator_rpi Signed-off-by: Sven Eckelmann <[email protected]>
fix plugin config doc Co-authored-by: CharlemagneLasse <[email protected]>
|
sorry for the ping @Arksine but is there any chance this will be merged? |
| [self.ke_exec, "--config_moonraker_url", self.url, "post-process", | ||
| f"\"{path}\""]) | ||
| logging.info(f"Running {cmd}") | ||
| timeout = 10. |
There was a problem hiding this comment.
During my experimentations, I've noticed that the rpi4 is often not able to process the gcode files in 10 seconds. I've now increased it for me to 120s inside the code. Not sure if it would be better to make it configurable from the outside.
There was a problem hiding this comment.
I think it's worth adding as a config, I'll add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to pipe gcode through klipper_estimator.
Related feature request: #481