Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chemprot dataset #138

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Add Chemprot dataset #138

merged 10 commits into from
Jul 18, 2024

Conversation

kai-car
Copy link
Collaborator

@kai-car kai-car commented Jul 16, 2024

Created loading script chemprot.py for ChemProt dataset available on Hugging Face bigbio/chemprot and associated test script test_chemprot.py. Currently all tests run successfully. However, still working on completion.
(Note: The first pull request #137 was closed due to rebasing the branch)

Finally, this will include:

  • requirements.txt
  • test HF dataset
  • document type
  • HF example <-> document
  • test HF example <-> document
  • test PIE dataset
  • document converts
  • test document converters
  • README.md

@kai-car kai-car requested a review from ArneBinder July 16, 2024 15:38
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 92.23301% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.23%. Comparing base (38b9580) to head (c251c02).
Report is 2 commits behind head on main.

Files Patch % Lines
dataset_builders/pie/chemprot/chemprot.py 92.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   91.40%   92.23%   +0.83%     
==========================================
  Files          10        1       -9     
  Lines         814      103     -711     
==========================================
- Hits          744       95     -649     
+ Misses         70        8      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kai-car
Copy link
Collaborator Author

kai-car commented Jul 17, 2024

From my perspective general functionality of chemprot.py implemented. Although some minor changes might still be needed.

Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some minors.

@kai-car kai-car requested a review from ArneBinder July 18, 2024 08:46
@ArneBinder ArneBinder merged commit 5bdcaca into main Jul 18, 2024
5 checks passed
@ArneBinder ArneBinder deleted the chemprot-dataset-2 branch July 18, 2024 11:52
@ArneBinder ArneBinder changed the title Chemprot dataset [WIP] Chemprot dataset Jul 18, 2024
@ArneBinder ArneBinder changed the title Chemprot dataset add Chemprot dataset Jul 18, 2024
@kai-car kai-car changed the title add Chemprot dataset Add Chemprot dataset Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants