Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biorel: remove warning when entity name is not the same as the span text #139

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ArneBinder
Copy link
Owner

in convert_to_text_document_with_labeled_spans_and_binary_relations . This was missed in #134.

Having the warning was a problem because it happened quite often, e.g. at least 200 times for train set with length of 114000, which would spam the console when using the converter.

…ary_relations when entity name is not the same as the span text
@ArneBinder ArneBinder added the bug Something isn't working label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (937a954) to head (3dfcc8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   96.82%   98.36%   +1.53%     
==========================================
  Files           1        1              
  Lines          63       61       -2     
==========================================
- Hits           61       60       -1     
+ Misses          2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder merged commit 1a19cdf into main Jul 17, 2024
5 checks passed
@ArneBinder ArneBinder deleted the biorel/remove-warning-for-name branch July 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant