Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tbga dataset #140

Merged
merged 18 commits into from
Jul 19, 2024
Merged

Add Tbga dataset #140

merged 18 commits into from
Jul 19, 2024

Conversation

kai-car
Copy link
Collaborator

@kai-car kai-car commented Jul 18, 2024

Created loading script tbga.py for TBGA dataset available on Hugging Face DFKI-SLT/tbga and associated test script test_tbga.py. Currently all tests should run successfully. However, still working on completion.

Finally, this will include:

  • requirements.txt
  • test HF dataset
  • document type
  • HF example <-> document
  • test HF example <-> document
  • test PIE dataset
  • document converts
  • test document converters
  • README.md

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.27%. Comparing base (5bdcaca) to head (84947ee).

Files Patch % Lines
dataset_builders/pie/tbga/tbga.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   92.23%   98.27%   +6.04%     
==========================================
  Files           1        1              
  Lines         103       58      -45     
==========================================
- Hits           95       57      -38     
+ Misses          8        1       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kai-car kai-car changed the title Tbga dataset [WIP] Tbga dataset Jul 19, 2024
@kai-car kai-car requested a review from ArneBinder July 19, 2024 09:12
@kai-car
Copy link
Collaborator Author

kai-car commented Jul 19, 2024

I rebased the tbga-dataset branch on main, updated project and pushed again. Hope everything worked correctly.

Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just one very minor thing.

tests/dataset_builders/pie/tbga/test_tbga.py Outdated Show resolved Hide resolved
@ArneBinder ArneBinder merged commit ae49e5d into main Jul 19, 2024
5 checks passed
@ArneBinder ArneBinder deleted the tbga-dataset branch July 19, 2024 12:06
@kai-car kai-car changed the title Tbga dataset Add Tbga dataset Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants