Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sciarg: fix partitioning #159

Merged
merged 3 commits into from
Nov 1, 2024
Merged

sciarg: fix partitioning #159

merged 3 commits into from
Nov 1, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 1, 2024

This PR

  • adds a test that asserts label counts for labeled_partitions
  • changes RegexPartitioner pattern to "<([^>/]+)>(?s:.)*?</\\1>": find matching tags non-greedy (*?), allow newlines in between (s flag) and capture the tag name

This affects only document A32 where the abstract was not identified before but now it is.

@ArneBinder ArneBinder added the bug Something isn't working label Nov 1, 2024
@ArneBinder ArneBinder force-pushed the sciarg/fix_partitioning branch from 98507f4 to c4f14b8 Compare November 1, 2024 16:32
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (06e3af5) to head (3086c6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #159      +/-   ##
===========================================
+ Coverage   92.46%   100.00%   +7.53%     
===========================================
  Files          10         1       -9     
  Lines         916        49     -867     
===========================================
- Hits          847        49     -798     
+ Misses         69         0      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder merged commit 2b3ba52 into main Nov 1, 2024
5 checks passed
@ArneBinder ArneBinder deleted the sciarg/fix_partitioning branch November 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant