Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in API when connectionProfileId is not specified but is required #811

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix panic in API when connectionProfileId is not specified but is required #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/arroyo-api/src/connection_tables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ async fn get_and_validate_connector(
connection_profile.config.clone(),
)
} else {
if connector.metadata().connection_config.is_some() {
return Err(bad_request("this connector requires a connection profile, but `connectionProfileId` was not specified"));
}
(None, json! {{}})
};

Expand Down
4 changes: 2 additions & 2 deletions webui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
<link rel="icon" href="/icon.png" type="image/png" />
<title>Arroyo Console</title>
<script>
const clusterId = "%VITE_CLUSTER_ID%";
const disableTelemetry = ("%VITE_DISABLE_TELEMETRY%" == "true");
const clusterId = "{{CLUSTER_ID}}";
const disableTelemetry = ("{{DISABLE_TELEMETRY}}" == "true" || "{{DISABLE_TELEMETRY}}" == "{{" + "DISABLE_TELEMETRY" + "}}");

if (!disableTelemetry) {
!function(t,e){var o,n,p,r;e.__SV||(window.posthog=e,e._i=[],e.init=function(i,s,a){function g(t,e){var o=e.split(".");2==o.length&&(t=t[o[0]],e=o[1]),t[e]=function(){t.push([e].concat(Array.prototype.slice.call(arguments,0)))}}(p=t.createElement("script")).type="text/javascript",p.async=!0,p.src=s.api_host+"/static/array.js",(r=t.getElementsByTagName("script")[0]).parentNode.insertBefore(p,r);var u=e;for(void 0!==a?u=e[a]=[]:a="posthog",u.people=u.people||[],u.toString=function(t){var e="posthog";return"posthog"!==a&&(e+="."+a),t||(e+=" (stub)"),e},u.people.toString=function(){return u.toString(1)+".people (stub)"},o="capture identify alias people.set people.set_once set_config register register_once unregister opt_out_capturing has_opted_out_capturing opt_in_capturing reset isFeatureEnabled onFeatureFlags".split(" "),n=0;n<o.length;n++)g(u,o[n]);e._i.push([i,s,a])},e.__SV=1)}(document,window.posthog||[]);
Expand Down
Loading