Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locheck: add support for linux. #56

Merged
merged 2 commits into from
May 3, 2024

Conversation

AnessZurba
Copy link
Contributor

Hi,

Full disclaimer: I'm no expert in running swift on Linux.

This is a try to make this project compatible with linux, the changes are very minimal, as the code doesn't use anything platform-specific (from what I can see)

Replace Darwin imports with Glibc, and a small change in Makefile to make it multi-platform

I did try to compile, install and run on ubuntu on a real iOS project with lots of localizations, it seems to work. (Although the version I ran was by replacing Darwin by Glibc, not the one with ifs)

Copy link
Collaborator

@stevelandeyasana stevelandeyasana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks! Looking forward to getting this landed and expanding our support.

Makefile Outdated
@@ -4,7 +4,7 @@ VERSION = 0.9.11

PREFIX = /usr/local
INSTALL_PATH = $(PREFIX)/bin/$(EXECUTABLE_NAME)
BUILD_PATH = .build/apple/Products/Release/$(EXECUTABLE_NAME)
BUILD_PATH = .build/release/$(EXECUTABLE_NAME)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this doesn't break the Mac build?

Copy link
Contributor Author

@AnessZurba AnessZurba May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it does, fixed now

@AnessZurba AnessZurba force-pushed the feature/linux-support branch from 535ccff to fabde4c Compare May 3, 2024 15:28
@AnessZurba AnessZurba force-pushed the feature/linux-support branch from fabde4c to 78dfcb0 Compare May 3, 2024 15:28
Copy link
Collaborator

@stevelandeyasana stevelandeyasana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll consider doing a release soon.

@stevelandeyasana stevelandeyasana merged commit 258bcb5 into Asana:main May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants