Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nodeBlsKey support #93

Merged
merged 2 commits into from
Feb 17, 2024
Merged

feat: add nodeBlsKey support #93

merged 2 commits into from
Feb 17, 2024

Conversation

leopaul36
Copy link
Contributor

@leopaul36 leopaul36 commented Feb 15, 2024

Linked issues

Dependencies

Changes

  • Added support for parsing nodeBlsKey from a file path
  • Added read_file_bytes_base64 to follow the same standard as the generate-bls-key -o command
  • Update the blueprints to add BLS keys

Additional comments

  • I added a following section to Cargo.toml to have a local dev dependency to ash_api. Not sure if it's the best way to go (EDIT: looks like cargo check does not like this).

@leopaul36 leopaul36 requested a review from Nuttymoon February 15, 2024 14:16
@Nuttymoon
Copy link
Contributor

Nuttymoon commented Feb 15, 2024

About your additional comment.

In this setup, we cannot run unit tests if the agent doesn't have access to ash-api-rs. We could give access to AshAvalancheBot to the repo and clone ash-api-rs in the CI pipeline.

Cargo.toml Outdated
Comment on lines 23 to 24
[patch.crates-io]
ash_api = { path = "../hai/ash-api-rs" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch is not appropriate here. We can just add a path field to the existing ash_cli dependency.

See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies

Copy link
Contributor Author

@leopaul36 leopaul36 Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we had that until 1ff639b

Should we just go back to this?

@Nuttymoon
Copy link
Contributor

FYI adding the nodeBlsKey field to the local node IDs won't impact the network validations (and the nodes won't have any BLS key registered on the P-Chain).

@leopaul36
Copy link
Contributor Author

FYI adding the nodeBlsKey field to the local node IDs won't impact the network validations (and the nodes won't have any BLS key registered on the P-Chain).

Should we remove the BLS keys from the blueprints then?

@Nuttymoon
Copy link
Contributor

FYI adding the nodeBlsKey field to the local node IDs won't impact the network validations (and the nodes won't have any BLS key registered on the P-Chain).

Should we remove the BLS keys from the blueprints then?

I don't think it has any negative impact + it's mandatory on the Juju side. We should just make sure that whenever they add static BLS keys to the local network genesis we change those.

@leopaul36 leopaul36 merged commit 6916228 into main Feb 17, 2024
1 check passed
@leopaul36 leopaul36 deleted the 92-add-nodeBlsKey-support branch February 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for nodeBlsKey for nodeId secrets
2 participants