-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nodeBlsKey support #93
Conversation
About your additional comment. In this setup, we cannot run unit tests if the agent doesn't have access to |
Cargo.toml
Outdated
[patch.crates-io] | ||
ash_api = { path = "../hai/ash-api-rs" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch
is not appropriate here. We can just add a path
field to the existing ash_cli
dependency.
See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we had that until 1ff639b
Should we just go back to this?
FYI adding the |
Should we remove the BLS keys from the blueprints then? |
I don't think it has any negative impact + it's mandatory on the Juju side. We should just make sure that whenever they add static BLS keys to the local network genesis we change those. |
Linked issues
nodeBlsKey
fornodeId
secrets #92Dependencies
Changes
nodeBlsKey
from a file pathread_file_bytes_base64
to follow the same standard as thegenerate-bls-key -o
commandAdditional comments
Cargo.toml
to have a local dev dependency toash_api
. Not sure if it's the best way to go (EDIT: looks likecargo check
does not like this).