feat: Typst Language Support #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
grantlemons
force-pushed
the
typst-support
branch
from
9a7ae81 to
6b5d78a
Compare
…of an environment's span
… possessives or conjunctions
…ove dict parsing to fit better
…ntent in span so quotes aren't escaped
grantlemons
force-pushed
the
typst-support
branch
from
6b5d78a to
550cf20
Compare
|
Mostly just needs more tests. I'm no expert in Typst syntax, so if someone wants to help it would be much appreciated. |
Andrew15-5
reviewed
Dec 18, 2024
|
If I can understand the core concepts mentioned above (what should/could be checked), then I maybe be able to add some tests. |
Andrew15-5
reviewed
Dec 20, 2024
…non-mut The parser trait's parse method took an &mut, but it wasn't used anywhere and was causing significant problems interacting with closures. If it is needed in the future, I would suggest creating a seperate mutable parse method.
…ctly handle optional components
- Only consolidate adjacent space spans - Typst spaces distinguish between newlines and spaces - Typst spaces count number of spaces - Spans command now defaults to not show newlines
- Remove unneeded &mut impl Parser in document
elijah-potter
requested changes
Dec 30, 2024
| @@ -284,6 +284,12 @@ impl Document { | |||
| } | |||
|
|
|||
| let child_tok = ©[cursor]; | |||
|
|
|||
| // Only condense adjacent spans | |||
| if start_tok.span.end != child_tok.span.start { | |||
There was a problem hiding this comment.
Add this change to condense_newlines as well.
There was a problem hiding this comment.
I did that originally, but it broke a test so I reverted it.
There was a problem hiding this comment.
The test might be wrong then.
There was a problem hiding this comment.
Ah, it's because newlines in comments need to be merged for paragraph breaks.
// I am a comment
//
// My span starts after the //
There is no paragraph break in between because the newline on line 2's span isn't contiguous with the newline at the end of line 1.
grantlemons
force-pushed
the
typst-support
branch
from
739ccc2 to
5f83275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening of #289 from my fork instead of a branch