refactor: Harper-ls Error-Handling Improvements #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to track issues in
harper_ls
. This changes appropriate to returnanyhow::Result
s, and in functions that can't, the anyhow error is logged in a concise way. These functions also add context to the anyhow error to make it easier to trace.Anyhow also ships with a macro
bail!()
, which simplifies forceable returns of new anyhow errors. For instance:Becomes: