-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreatsDataViews: ThreatModal integration #40202
base: add/protect/core
Are you sure you want to change the base?
ThreatsDataViews: ThreatModal integration #40202
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…nto add/components/threats-data-views-modal-integration
…omponents/threats-data-views-modal-integration
Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.
9745a5f
to
68569f2
Compare
|
||
const { wafSupported } = useWafData(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to avoid showing the Codeable redirect in the ThreatIgnoreDetails
component to Atomic users - could using wafSupported
make sense? I think it may be too broad of a check (and too WAF specific), but I am not sure how best to approach the restriction.
9a1cb0a
to
409ed95
Compare
#40057) Co-authored-by: Nate Weller <[email protected]>
* Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <[email protected]> --------- Co-authored-by: Nate Weller <[email protected]>
Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <[email protected]> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <[email protected]> --------- Co-authored-by: Nate Weller <[email protected]> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Dean Kmyta <[email protected]>
cfebba4
to
322819d
Compare
2a3f2fe
to
aac1879
Compare
Description
Integrates
ThreatModal
intoThreatsDataViews
. Adds an actionToConfirm flag so we can pass action/click context from the main component to the modal to render certain content conditionally.Note: This updates the
ScanThreatsDataViews
to account for the new modal subcomponents, but does not remove and existing modal infrastructure from Protect.A followup has been created to add support for bulk threats/actions: #40692
I have also drafted a rough proposal for improving navigation between individual and bulk views: #40720
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
ThreatModal
andThreatsDataViews