-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Show loading indicator as status icon when scan in progress #40624
base: add/protect/core
Are you sure you want to change the base?
Protect: Show loading indicator as status icon when scan in progress #40624
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
7aadefb
to
cc4dc36
Compare
4eb7f10
to
d17f3f7
Compare
cc4dc36
to
6cf16bd
Compare
d17f3f7
to
2f7cfc8
Compare
6cf16bd
to
b13df3f
Compare
aeb3c42
to
dc8c830
Compare
b13df3f
to
4335e70
Compare
dc8c830
to
7700614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks sounds, IMHO though having a scanning icon for each row is a little overkill, especially when all a site is approach 20 entries in the table. The icon in the header card let's us know its in progress, maybe thats enough? I suppose this is an effort to make it clear to the user that current data is live? I am not a design expert by any means, so the decision shouldn't be solely up to me but perhaps we should run this by the team for more opinions.
#40057) Co-authored-by: Nate Weller <[email protected]>
* Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <[email protected]> --------- Co-authored-by: Nate Weller <[email protected]>
Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.
4335e70
to
9a6e7ee
Compare
7700614
to
d860f37
Compare
2a3f2fe
to
aac1879
Compare
Proposed changes:
ScanReport
component to accept ascanInProgress: boolean
prop, which displays aSpinner
instead of aShieldIcon
in the "status" column when a scan is currently in progress.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions: