Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection test API path for WoA sites to fix broken connection notices not showing up #40732

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

manzoorwanijk
Copy link
Member

Currently, the broken connection notices are not shown on WoA sites because the connection test result uses the wrong endpoint which returns the data in an incorrect format.

Proposed changes:

  • Update the endpoint used for connection test results

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Using Jetpack Beta Tester plugin, activate this branch on your WoA site
  • Add at least one social connection like Facebook or Mastodon
  • Edit a post in Block Editor
  • Open Jetpack sidebar
  • Select at least one connection and click on "Share post"
  • Confirm that the post is shared successfully
  • Now break the connection by removing "Jetpack" from Facebook or Mastodon
  • Goto the editor again
  • Now verify that that you see the notice about the broken connection
Screenshot 2024-12-26 at 10 20 32 AM

@manzoorwanijk manzoorwanijk added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review labels Dec 26, 2024
@manzoorwanijk manzoorwanijk requested a review from a team December 26, 2024 04:51
@manzoorwanijk manzoorwanijk self-assigned this Dec 26, 2024
Copy link
Contributor

github-actions bot commented Dec 26, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/connection-tests-for-woa branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/connection-tests-for-woa
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Dec 26, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@manzoorwanijk
Copy link
Member Author

I have tested it thoroughly and it works fine.

@manzoorwanijk manzoorwanijk merged commit 8e4dd7c into trunk Dec 26, 2024
63 checks passed
@manzoorwanijk manzoorwanijk deleted the fix/connection-tests-for-woa branch December 26, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant