Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bug color palettes #40846

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix/bug color palettes #40846

wants to merge 2 commits into from

Conversation

valterlorran
Copy link
Contributor

Closes Automattic/themes#8553

Proposed changes:

  • We got a report that the color palettes were not showing up for the user. Upon visiting the code, I noticed that a condition would not work if only three palettes were returned from the endpoint, as the code only worked for six or more palettes.
  • I updated the conditions to accept three palettes.

Before:

Captura de Tela 2025-01-02 às 13 15 15

After:

399749995-6ebc4c91-de83-4145-9380-df4b6172d914

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Create a new Business site, mark it as a WoA Dev site, and take it Atomic.
  2. Apply this change to your Atomic site
  3. Apply the Rockfield theme to your site.
  4. Go to Appearance -> Customize -> Colors & Background.
  5. You should now see the color palettes.

@valterlorran valterlorran requested a review from ramonjd January 3, 2025 19:27
@valterlorran valterlorran self-assigned this Jan 3, 2025
@valterlorran valterlorran requested a review from a team January 3, 2025 19:28
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added [Plugin] Wpcomsh [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 3, 2025
@valterlorran valterlorran added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Wpcomsh [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The color palette in the Customizer is not showing.
1 participant