fix: always show email address for order summaries #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#1550 introduced a custom template to force the "order summary" to appear in the thank-you template when completing a transaction using an email address that's already registered on the site. However, this custom template inherited some logic which only exposed the order's email address if it matches the currently logged-in user. Since this template is only shown in scenarios where a non-logged-in user is completing a transaction using an existing account's email, that condition will never be satisfied, so this PR removes the logic and always shows the email address in the order summary. This should be safe because we're checking the order key before showing order summary details to ensure that the order details are only shown during the course of a checkout flow involving that exact order.
How to test the changes in this Pull Request:
release
, observe that no email address is shown on the thank you screen.Other information: