Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always show email address for order summaries #1554

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 11, 2023

All Submissions:

Changes proposed in this Pull Request:

#1550 introduced a custom template to force the "order summary" to appear in the thank-you template when completing a transaction using an email address that's already registered on the site. However, this custom template inherited some logic which only exposed the order's email address if it matches the currently logged-in user. Since this template is only shown in scenarios where a non-logged-in user is completing a transaction using an existing account's email, that condition will never be satisfied, so this PR removes the logic and always shows the email address in the order summary. This should be safe because we're checking the order key before showing order summary details to ensure that the order details are only shown during the course of a checkout flow involving that exact order.

How to test the changes in this Pull Request:

  1. Complete testing steps for fix: match thankyou template when using existing customer email #1550.
  2. On release, observe that no email address is shown on the thank you screen.
  3. On this branch, confirm that the email address is shown.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Oct 11, 2023
@dkoo dkoo requested a review from a team as a code owner October 11, 2023 19:43
@dkoo dkoo merged commit 33952d1 into release Oct 12, 2023
2 checks passed
@dkoo dkoo deleted the hotfix/restore-email-for-existing-account-orders branch October 12, 2023 18:55
matticbot pushed a commit that referenced this pull request Oct 12, 2023
## [1.75.5](v1.75.4...v1.75.5) (2023-10-12)

### Bug Fixes

* always show email address for order summaries ([#1554](#1554)) ([33952d1](33952d1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.75.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants