-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal-checkout): allow all gateway assets #1988
fix(modal-checkout): allow all gateway assets #1988
Conversation
6767111
to
2dd48b8
Compare
* | ||
* @var string[] | ||
*/ | ||
private static $allowed_styles = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I separated these out so we can be more explicit with our hooks but wasn't sure which of these were for scripts and which were for styles. Since this is time sensitive I didn't want to let this hold up this PR.
312773b
to
95d58a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chickenn00dle, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [4.5.0-alpha.3](v4.5.0-alpha.2...v4.5.0-alpha.3) (2024-12-06) ### Bug Fixes * **modal-checkout:** allow all gateway assets ([#1988](#1988)) ([e371e30](e371e30)) * **modal-checkout:** handle paypal ([#1985](#1985)) ([9bb2b8c](9bb2b8c)) ### Features * add CSS class to variation buttons for tracking ([#1989](#1989)) ([910e6b1](910e6b1))
🎉 This PR is included in version 4.5.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.5.0](v4.4.0...v4.5.0) (2024-12-09) ### Bug Fixes * also search for coauthor posts by term slug ([#1954](#1954)) ([49357ff](49357ff)) * **modal-checkout:** allow all gateway assets ([#1988](#1988)) ([e371e30](e371e30)) * **modal-checkout:** handle paypal ([#1985](#1985)) ([9bb2b8c](9bb2b8c)) * **ras-acc:** correct spacing issue around saved credit cards ([#1980](#1980)) ([52a5c57](52a5c57)) * **ras-acc:** fix display issues with Additional Fields ([#1979](#1979)) ([b9390ef](b9390ef)) * **ras-acc:** remove space caused by empty divs ([#1978](#1978)) ([8cb6ead](8cb6ead)) * remove reCaptcha for WooCommere code from modal checkout ([#1984](#1984)) ([8e250eb](8e250eb)) ### Features * add Bluesky support to the Author Profile, List blocks ([#1969](#1969)) ([d26a7e4](d26a7e4)) * add CSS class to variation buttons for tracking ([#1989](#1989)) ([910e6b1](910e6b1)) * add support for Newspack Guest Contributor in HPP blocks ([#1934](#1934)) ([c16849e](c16849e)) * merge RAS-ACC work into trunk ([#1977](#1977)) ([2eeaa89](2eeaa89))
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR makes it so modal checkout allows all scripts and styles from available payment gateways by default.
How to test the changes in this Pull Request:
ppcp
scripts/styles via network dev tools tab)Other information: