Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak modal iframe size #2006

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: tweak modal iframe size #2006

merged 1 commit into from
Dec 17, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR is a small tweak to the default iframe size on load (thanks @thomasguillot!).

See p1734437900696829-slack-newspack-reader-activation.

How to test the changes in this Pull Request:

  1. Apply the PR and run npm run build
  2. Load the modal checkout.
  3. Confirm the iframe's initial size uses --newspack-ui-spacer-9, not --newspack-ui-spacer-8 (the 48px fallback is correct, though). Note: the applied height will be overridden by inline JS.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner December 17, 2024 16:27
@thomasguillot
Copy link
Contributor

thomasguillot commented Dec 17, 2024

I'm not a developer, but I approve this PR!

Edit: I can't approve this PR 🤣

@laurelfulford
Copy link
Contributor Author

Thanks @chickenn00dle and @thomasguillot!

@laurelfulford laurelfulford merged commit fef66e1 into trunk Dec 17, 2024
8 checks passed
@laurelfulford laurelfulford deleted the fix/modal-iframe-size branch December 17, 2024 17:54
Copy link

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants